Bug 93970

Summary: REGRESSION r125500: 7 tests crashing on Mac bots
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: Tools / TestsAssignee: Thomas Sepez <tsepez>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, eric, tsepez, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://build-safari.apple.com/results/Mountain%20Lion%20Debug%20Tests/r125500_44228%20(2510)/results.html
Attachments:
Description Flags
Patch none

Eric Carlson
Reported 2012-08-14 08:26:59 PDT
The following tests started crashing on the Mac bots between r125497 and r125500 (inclusive): http/tests/security/contentSecurityPolicy/object-src-url-blocked.html userscripts/user-script-top-frame-only.html fast/loader/reload-zero-byte-plugin.html fast/frames/iframe-plugin-load-remove-document-crash.html plugins/plugin-document-back-forward.html plugins/return-error-from-new-stream-doesnt-invoke-destroy-stream.html plugins/inner-html-display-none.html http://trac.webkit.org/log/trunk?rev=125500&stop_rev=125497&limit=5 http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r125495%20%282315%29/results.html succeeded http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r125500%20%282316%29/results.html failed
Attachments
Patch (1.39 KB, patch)
2012-08-14 11:50 PDT, Thomas Sepez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thomas Sepez
Comment 1 2012-08-14 09:44:14 PDT
Undoubtedly fallout from https://bugs.webkit.org/show_bug.cgi?id=93283. Eric, I'd suggest putting the NULL checks back in for the other ports that we'd agreed to remove from the original patch.
Eric Carlson
Comment 2 2012-08-14 09:52:39 PDT
(In reply to comment #1) > Undoubtedly fallout from https://bugs.webkit.org/show_bug.cgi?id=93283. Eric, I'd suggest putting the NULL checks back in for the other ports that we'd agreed to remove from the original patch. I don't have access to the bug. Can you fix it?
Thomas Sepez
Comment 3 2012-08-14 11:50:10 PDT
Created attachment 158387 [details] Patch
Eric Seidel (no email)
Comment 4 2012-08-14 12:16:49 PDT
Comment on attachment 158387 [details] Patch OK.
WebKit Review Bot
Comment 5 2012-08-14 14:02:39 PDT
Comment on attachment 158387 [details] Patch Clearing flags on attachment: 158387 Committed r125601: <http://trac.webkit.org/changeset/125601>
WebKit Review Bot
Comment 6 2012-08-14 14:02:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.