Bug 93943 – [Forms] Copy Source/WebCore/html/shadow/TextControlInnerElements.{cpp,h} to SpinButtonElement.{cpp,h}

• Component: Forms
• Status: RESOLVED FIXED

This is part of setting SpinButtonElement free from HTMLInputElement.

Created attachment 158266 [details]
Patch 1

Comment on attachment 158266 [details]
Patch 1

Could you review this patch?
Thanks in advance.

Note: The diff is result of "svn copy".

[WebKit Review Bot]

Attachment 158266 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/html/shadow/SpinButtonElement.h:27:  #ifndef header guard has wrong style, please use: SpinButtonElement_h  [build/header_guard] [5]
Source/WebCore/html/shadow/SpinButtonElement.h:178:  The parameter name "state" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/html/shadow/SpinButtonElement.cpp:28:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebCore/html/shadow/SpinButtonElement.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kent Tamura]

Comment on attachment 158266 [details]
Patch 1

ok

Landed: http://trac.webkit.org/changeset/125862