Bug 93918

Summary: [Chromium] Patch CCThreadProxy to call setTimebaseAndInterval on CCScheduler
Product: WebKit Reporter: John Bates <jbates>
Component: New BugsAssignee: John Bates <jbates>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

John Bates
Reported 2012-08-13 17:55:32 PDT
[Chromium] Patch CCThreadProxy to call setTimebaseAndInterval on CCScheduler
Attachments
Patch (3.44 KB, patch)
2012-08-13 17:56 PDT, John Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Bates
Comment 1 2012-08-13 17:56:54 PDT
Created attachment 158173 [details] Patch
James Robinson
Comment 2 2012-08-13 18:00:16 PDT
Comment on attachment 158173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158173&action=review > Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp:81 > + TRACE_EVENT1("cc", "CCFrameRateController::setActive", "active", active); This seems unnecessarily spammy, can you put it below the early-out? When would we want to know about redundant sets?
John Bates
Comment 3 2012-08-13 18:01:52 PDT
Comment on attachment 158173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158173&action=review >> Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp:81 >> + TRACE_EVENT1("cc", "CCFrameRateController::setActive", "active", active); > > This seems unnecessarily spammy, can you put it below the early-out? When would we want to know about redundant sets? For debugging it's helpful to see. I will change it back once we've got the new thread code working.
James Robinson
Comment 4 2012-08-13 18:06:55 PDT
Comment on attachment 158173 [details] Patch OK
WebKit Review Bot
Comment 5 2012-08-13 19:54:13 PDT
Comment on attachment 158173 [details] Patch Clearing flags on attachment: 158173 Committed r125504: <http://trac.webkit.org/changeset/125504>
WebKit Review Bot
Comment 6 2012-08-13 19:54:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.