Bug 93914

Summary: IndexedDB: add tracing to IDBLevelDBBackingStore
Product: WebKit Reporter: Alec Flett <alecflett>
Component: New BugsAssignee: Alec Flett <alecflett>
Status: RESOLVED FIXED    
Severity: Normal CC: dgrogan, jsbell, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Alec Flett
Reported 2012-08-13 17:30:29 PDT
IndexedDB: add tracing to IDBLevelDBBackingStore
Attachments
Patch (16.63 KB, patch)
2012-08-13 17:31 PDT, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch (16.71 KB, patch)
2012-08-14 13:14 PDT, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.73 KB, patch)
2012-08-14 17:33 PDT, Alec Flett 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alec Flett
Comment 1 2012-08-13 17:31:43 PDT
Created attachment 158158 [details] Patch
Alec Flett
Comment 2 2012-08-14 11:40:22 PDT
pretty straight forward - also I moved the static findKeyInIndex into IDBLevelDBBackingStore because I want to mess with its const-ness for bug 91127, and since I was adding a IDB_TRACE... jsbell@ / dgrogan@ - any objections?
Joshua Bell
Comment 3 2012-08-14 11:54:04 PDT
Comment on attachment 158158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158158&action=review LGTM (Could quibble about including the refactoring here vs. in 91127, but it's harmless.) > Source/WebCore/ChangeLog:10 > + from core IDB slowness. Add note about moving findKeyInIndex > Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h:88 > + Nit: Remove this blank line. > Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h:89 > + bool findKeyInIndex(int64_t databaseId, int64_t objectStoreId, int64_t indexId, const IDBKey&, Vector<char>& foundEncodedPrimaryKey); Need to expose this in IDBBackingStore too?
Alec Flett
Comment 4 2012-08-14 13:14:32 PDT
Comment on attachment 158158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158158&action=review >> Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h:89 >> + bool findKeyInIndex(int64_t databaseId, int64_t objectStoreId, int64_t indexId, const IDBKey&, Vector<char>& foundEncodedPrimaryKey); > > Need to expose this in IDBBackingStore too? Nope, only used by members of this class.
Alec Flett
Comment 5 2012-08-14 13:14:43 PDT
Created attachment 158401 [details] Patch
Alec Flett
Comment 6 2012-08-14 13:15:19 PDT
tony@ - r?
Tony Chang
Comment 7 2012-08-14 17:26:24 PDT
Comment on attachment 158401 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158401&action=review > Source/WebCore/ChangeLog:15 > + No new tests (OOPS!). You need to update this line for why there are no tests.
Alec Flett
Comment 8 2012-08-14 17:33:14 PDT
Created attachment 158455 [details] Patch for landing
WebKit Review Bot
Comment 9 2012-08-14 18:18:40 PDT
Comment on attachment 158455 [details] Patch for landing Clearing flags on attachment: 158455 Committed r125627: <http://trac.webkit.org/changeset/125627>
WebKit Review Bot
Comment 10 2012-08-14 18:18:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.