Bug 93907 – [chromium] Make WebAnimation a pure virtual interface to hide implementation and avoid unresolved symbols

• Component: New Bugs
• Status: RESOLVED FIXED

[James Robinson]

[chromium] Make WebAnimation a pure virtual interface to hide implementation and avoid unresolved symbols

[James Robinson]

Created attachment 158134 [details]
Patch

[James Robinson]

Darin - is this what you had in mind?  If so I'll go ahead and convert the rest of the WebPrivateOwnPtr<> types in the compositor interface family over and introduce a tearoff factory section to Platform.h's exported thingies.

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[James Robinson]

Committed r125469: <http://trac.webkit.org/changeset/125469>

[Darin Fisher (:fishd, Google)]

Comment on attachment 158134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158134&action=review

> Source/Platform/chromium/public/WebAnimation.h:53
> +    WEBKIT_EXPORT static WebAnimation* create(const WebAnimationCurve&, TargetProperty);

Just to be clear about what we discussed, a future step would be to turn these static functions into
virtual functions of some factory interface (i.e., CompositorSupport::createAnimation).