| Summary: | [chromium] Make WebAnimation a pure virtual interface to hide implementation and avoid unresolved symbols | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, cc-bugs, dglazkov, enne, fishd, tkent+wkapi, vollick, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
James Robinson
2012-08-13 15:32:53 PDT
Created attachment 158134 [details]
Patch
Darin - is this what you had in mind? If so I'll go ahead and convert the rest of the WebPrivateOwnPtr<> types in the compositor interface family over and introduce a tearoff factory section to Platform.h's exported thingies. Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Committed r125469: <http://trac.webkit.org/changeset/125469> Comment on attachment 158134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158134&action=review > Source/Platform/chromium/public/WebAnimation.h:53 > + WEBKIT_EXPORT static WebAnimation* create(const WebAnimationCurve&, TargetProperty); Just to be clear about what we discussed, a future step would be to turn these static functions into virtual functions of some factory interface (i.e., CompositorSupport::createAnimation). |