Summary: | Enable CSS Sticky Position on Windows. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Roger Fong <roger_fong> | ||||||||||||
Component: | CSS | Assignee: | Roger Fong <roger_fong> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | simon.fraser, thorton, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | PC | ||||||||||||||
OS: | Windows 7 | ||||||||||||||
Attachments: |
|
Description
Roger Fong
2012-08-13 15:19:51 PDT
Created attachment 158133 [details]
patch
There may have been a define that was not in it's proper alphabetized location (also the indentation was completely off) and it happened to be right where I was going to put the new define...
I may have fixed it here as well...
Created attachment 158137 [details]
re-patch
I'm a hypocrite and screwed the style up myself
Created attachment 158138 [details]
re-re-patch
Comment on attachment 158138 [details] re-re-patch Rejecting attachment 158138 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 47>At revision 63. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13500004 Created attachment 158155 [details]
updated to lastest revision...although it shouldn't have mattered
Comment on attachment 158155 [details] updated to lastest revision...although it shouldn't have mattered View in context: https://bugs.webkit.org/attachment.cgi?id=158155&action=review > WebKitLibraries/ChangeLog:4 > + Need the bug URL (OOPS!). Oops. Bad reviewer. Created attachment 158159 [details]
forgot the url
Comment on attachment 158159 [details] forgot the url Clearing flags on attachment: 158159 Committed r125485: <http://trac.webkit.org/changeset/125485> All reviewed patches have been landed. Closing bug. |