Summary: | [Qt] Clean up exception handling | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Hausmann <hausmann> | ||||
Component: | New Bugs | Assignee: | Simon Hausmann <hausmann> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cmarcelo, kenneth | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 60842 | ||||||
Attachments: |
|
Description
Simon Hausmann
2012-08-13 12:18:11 PDT
Created attachment 158070 [details]
Patch
Comment on attachment 158070 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158070&action=review > Source/WebCore/ChangeLog:10 > + was thrown. Naturally the caller must store that ValueRef on the stack in order to get caught > + by the garbage collector, otherwise the callee would have to use JSValueProtect on it. you want it to be garbage collected? (In reply to comment #2) > (From update of attachment 158070 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=158070&action=review > > > Source/WebCore/ChangeLog:10 > > + was thrown. Naturally the caller must store that ValueRef on the stack in order to get caught > > + by the garbage collector, otherwise the callee would have to use JSValueProtect on it. > > you want it to be garbage collected? No :) caught in the sense of _marked_ so that the GC does not delete it on the heap. (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 158070 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=158070&action=review > > > > > Source/WebCore/ChangeLog:10 > > > + was thrown. Naturally the caller must store that ValueRef on the stack in order to get caught > > > + by the garbage collector, otherwise the callee would have to use JSValueProtect on it. > > > > you want it to be garbage collected? > > No :) caught in the sense of _marked_ so that the GC does not delete it on the heap. I guessed so, maybe that could be rewritten to be more clear for non JS guys like me. (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 158070 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=158070&action=review > > > > > > > Source/WebCore/ChangeLog:10 > > > > + was thrown. Naturally the caller must store that ValueRef on the stack in order to get caught > > > > + by the garbage collector, otherwise the callee would have to use JSValueProtect on it. > > > > > > you want it to be garbage collected? > > > > No :) caught in the sense of _marked_ so that the GC does not delete it on the heap. > > I guessed so, maybe that could be rewritten to be more clear for non JS guys like me. Good point, will do :) LGTM. Committed r125439: <http://trac.webkit.org/changeset/125439> |