Bug 93864

Summary: Media(Stream|Element)AudioSourceNode should be guarded by the WEB_AUDIO condition as well
Product: WebKit Reporter: Zan Dobersek <zan>
Component: Web AudioAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, crogers, eric.carlson, feature-media-reviews, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2012-08-13 10:38:11 PDT
Currently the MediaStreamAudioSourceNode lists only the MEDIA_SOURCE feature under the Conditional attribute. The compilation then fails when the MEDIA_STREAM feature is enabled but the WEB_AUDIO feature is not. Both guards are used in MediaStreamAudioSourceNode.cpp but only MEDIA_STREAM in MediaStreamAudioSourceNode.h.
Attachments
Patch (2.11 KB, patch)
2012-08-13 10:49 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (3.00 KB, patch)
2012-08-13 11:03 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-08-13 10:49:54 PDT
Created attachment 158041 [details] Patch
Zan Dobersek
Comment 2 2012-08-13 10:54:50 PDT
MediaElementAudioSourceNode suffers the same issue, meaning there would be compilation errors when enabling WEB_AUDIO and disabling the VIDEO feature. Just to make it clear, the GTK port intends to include all the files into the build, regardless of any feature being enabled or not. The GTK port currently enables the MEDIA_STREAM feature and disables WEB_AUDIO, and that's where the errors were first noticed.
Zan Dobersek
Comment 3 2012-08-13 10:55:32 PDT
Changing the title accordingly, uploading a new patch soon.
Zan Dobersek
Comment 4 2012-08-13 11:03:32 PDT
Created attachment 158046 [details] Patch
WebKit Review Bot
Comment 5 2012-08-13 13:18:13 PDT
Comment on attachment 158046 [details] Patch Clearing flags on attachment: 158046 Committed r125440: <http://trac.webkit.org/changeset/125440>
WebKit Review Bot
Comment 6 2012-08-13 13:18:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.