Summary: | Media(Stream|Element)AudioSourceNode should be guarded by the WEB_AUDIO condition as well | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
Component: | Web Audio | Assignee: | Zan Dobersek <zan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, crogers, eric.carlson, feature-media-reviews, ojan, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Zan Dobersek
2012-08-13 10:38:11 PDT
Created attachment 158041 [details]
Patch
MediaElementAudioSourceNode suffers the same issue, meaning there would be compilation errors when enabling WEB_AUDIO and disabling the VIDEO feature. Just to make it clear, the GTK port intends to include all the files into the build, regardless of any feature being enabled or not. The GTK port currently enables the MEDIA_STREAM feature and disables WEB_AUDIO, and that's where the errors were first noticed. Changing the title accordingly, uploading a new patch soon. Created attachment 158046 [details]
Patch
Comment on attachment 158046 [details] Patch Clearing flags on attachment: 158046 Committed r125440: <http://trac.webkit.org/changeset/125440> All reviewed patches have been landed. Closing bug. |