Bug 93860

Summary: Plumb through EXT_debug_marker entry points
Product: WebKit Reporter: Gregg Tavares <gman>
Component: WebGLAssignee: Gregg Tavares <gman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, dglazkov, fishd, jamesr, kbr, noam, tkent+wkapi, webkit.review.bot, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Gregg Tavares
Reported 2012-08-13 09:37:17 PDT
Plumb through EXT_debug_marker entry points
Attachments
Patch (11.38 KB, patch)
2012-08-13 09:44 PDT, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Patch (11.73 KB, patch)
2012-08-13 10:19 PDT, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Patch (11.91 KB, patch)
2012-08-13 18:16 PDT, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gregg Tavares
Comment 1 2012-08-13 09:44:53 PDT
Created attachment 158024 [details] Patch
Gregg Tavares
Comment 2 2012-08-13 10:19:42 PDT
Created attachment 158033 [details] Patch
WebKit Review Bot
Comment 3 2012-08-13 10:23:16 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Kenneth Russell
Comment 4 2012-08-13 11:16:43 PDT
Comment on attachment 158033 [details] Patch Looks fine; r=me. Let's wait for it to clear the EWS before setting cq+.
WebKit Review Bot
Comment 5 2012-08-13 11:26:33 PDT
Comment on attachment 158033 [details] Patch Attachment 158033 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13480835
Gregg Tavares
Comment 6 2012-08-13 18:16:33 PDT
Created attachment 158176 [details] Patch
Kenneth Russell
Comment 7 2012-08-13 18:26:43 PDT
Comment on attachment 158176 [details] Patch r=me again
WebKit Review Bot
Comment 8 2012-08-13 23:51:13 PDT
Comment on attachment 158176 [details] Patch Rejecting attachment 158176 [details] from commit-queue. gman@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Review Bot
Comment 9 2012-08-14 10:52:04 PDT
Comment on attachment 158176 [details] Patch Clearing flags on attachment: 158176 Committed r125580: <http://trac.webkit.org/changeset/125580>
WebKit Review Bot
Comment 10 2012-08-14 10:52:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.