Bug 93834 – [V8] Move hintForGCIfNecessary() from V8Proxy.h to V8GCController.h

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Kentaro Hara]

We can move hintForGCIfNecessary() from V8Proxy.h to V8GCController.h.

[Kentaro Hara]

Created attachment 157975 [details]
Patch

[Adam Barth]

Comment on attachment 157975 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157975&action=review

> Source/WebCore/bindings/v8/V8GCController.cpp:525
> +    if (data->shouldCollectGarbageSoon()) {

Prefer early return.

> Source/WebCore/bindings/v8/V8GCController.cpp:526
> +        const int longIdlePauseInMs = 1000;

longIdlePauseInMs -> longIdlePauseInMS

> Source/WebCore/bindings/v8/V8GCController.h:79
> +        static void hintForGCIfNecessary();

Can we think of a better name for this function?  Perhaps collectGarbageIfNecessary?

[Kentaro Hara]

(In reply to comment #2)
> > Source/WebCore/bindings/v8/V8GCController.cpp:525
> > +    if (data->shouldCollectGarbageSoon()) {
> 
> Prefer early return.
> 
> > Source/WebCore/bindings/v8/V8GCController.cpp:526
> > +        const int longIdlePauseInMs = 1000;
> 
> longIdlePauseInMs -> longIdlePauseInMS
> 
> > Source/WebCore/bindings/v8/V8GCController.h:79
> > +        static void hintForGCIfNecessary();
> 
> Can we think of a better name for this function?  Perhaps collectGarbageIfNecessary?

Done.

[Kentaro Hara]

Committed r125491: <http://trac.webkit.org/changeset/125491>