Summary: | Share common code between calendar picker and color suggestion picker | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keishi Hattori <keishi> | ||||||||||||
Component: | Forms | Assignee: | Keishi Hattori <keishi> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | dglazkov, tkent, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Keishi Hattori
2012-08-13 01:29:16 PDT
Created attachment 157939 [details]
Patch
Comment on attachment 157939 [details] Patch Attachment 157939 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13481744 New failing tests: platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html Created attachment 157967 [details]
Archive of layout-test-results from gce-cr-linux-02
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment on attachment 157939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157939&action=review > Source/WebCore/ChangeLog:8 > + Moved common code between calandarPicker and colorSuggestionPicker into pickerCommon.{js,css} I recommend not addressing two things in one patch. This patch can be split into 1. Move files to Resources/pagepopup/ and 2. Sharing common code. > Source/WebCore/ChangeLog:12 > + * Resources/pagepopup/calendarPicker.css: Renamed from Source/WebCore/Resources/calendarPicker.css. Probably Resources/pagepopups/ is better? > Source/WebCore/ChangeLog:25 > + We had better update ManualTests/forms/calendar-picker.html and color-suggestion-picker.html. Created attachment 158322 [details]
Patch
Comment on attachment 158322 [details] Patch Attachment 158322 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13504193 New failing tests: platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance.html platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance.html platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html Created attachment 158331 [details]
Archive of layout-test-results from gce-cr-linux-03
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 158482 [details]
Patch
Comment on attachment 158482 [details]
Patch
ok
Comment on attachment 158482 [details] Patch Clearing flags on attachment: 158482 Committed r125641: <http://trac.webkit.org/changeset/125641> All reviewed patches have been landed. Closing bug. |