Bug 93798

Summary: Implement absolutely positioned flex items
Product: WebKit Reporter: Tony Chang <tony>
Component: Layout and RenderingAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Tony Chang 2012-08-13 00:00:29 PDT 
This has changed recently:
http://dev.w3.org/csswg/css3-flexbox/#abspos-items

If I read this properly, it's saying that absolutely positioned items are positioned relative to the flex line it is on.  I think the current code is using placeholders in the flex line.
Comment 1 Tony Chang 2012-09-20 11:29:00 PDT 
Created attachment 164954 [details]
Patch
Comment 2 Ojan Vafai 2012-09-20 11:46:42 PDT 
Comment on attachment 164954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164954&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:962
> +size_t RenderFlexibleBox::numberOfInFlowPositionedChildren(const OrderedFlexItemList& children) const

Nit: could make this a static and not need to add it to the header.
Comment 3 Build Bot 2012-09-20 11:48:13 PDT 
Comment on attachment 164954 [details]
Patch

Attachment 164954 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13958259
Comment 4 Tony Chang 2012-09-20 11:56:31 PDT 
Created attachment 164958 [details]
Patch for landing
Comment 5 Tony Chang 2012-09-20 11:56:49 PDT 
Comment on attachment 164954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164954&action=review

>> Source/WebCore/rendering/RenderFlexibleBox.cpp:962
>> +size_t RenderFlexibleBox::numberOfInFlowPositionedChildren(const OrderedFlexItemList& children) const
> 
> Nit: could make this a static and not need to add it to the header.

I considered that, but that involves making OrderedFlexItemList non-private, which would still touch the header and seems worse (only RenderFlexbox should be using this type).
Comment 6 Ojan Vafai 2012-09-20 11:58:18 PDT 
Comment on attachment 164954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164954&action=review

>>> Source/WebCore/rendering/RenderFlexibleBox.cpp:962
>>> +size_t RenderFlexibleBox::numberOfInFlowPositionedChildren(const OrderedFlexItemList& children) const
>> 
>> Nit: could make this a static and not need to add it to the header.
> 
> I considered that, but that involves making OrderedFlexItemList non-private, which would still touch the header and seems worse (only RenderFlexbox should be using this type).

Ah, right. NM.
Comment 7 WebKit Review Bot 2012-09-20 12:29:31 PDT 
Comment on attachment 164958 [details]
Patch for landing

Clearing flags on attachment: 164958

Committed r129154: <http://trac.webkit.org/changeset/129154>
Comment 8 WebKit Review Bot 2012-09-20 12:29:34 PDT 
All reviewed patches have been landed.  Closing bug.