Summary: | REGRESSION(r125153): It broke the 'Unexpected no expected results' case | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Critical | CC: | galpeter, lforschler, ossy, rniwa, wsiegrist, zherczeg | ||||
Priority: | P1 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 93537 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2012-08-12 16:18:03 PDT
This regex is the culprit re.compile(r'(no expected results found|missing results)\s*:\s+\((\d+)\)') Because of the new parentheses the text is the first matching group. The text should be a non-capturing group, like this: re.compile(r'(?:no expected results found|missing results)\s*:\s+\((\d+)\)') (In reply to comment #1) > This regex is the culprit > > re.compile(r'(no expected results found|missing results)\s*:\s+\((\d+)\)') > > Because of the new parentheses the text is the first matching group. The text should be a non-capturing group, like this: > > re.compile(r'(?:no expected results found|missing results)\s*:\s+\((\d+)\)') Could you upload a patch for it? ;-) Created attachment 157932 [details]
regex fix
Should fix it (TM) :)
Comment on attachment 157932 [details]
regex fix
LGTM,r=me.
Comment on attachment 157932 [details] regex fix Clearing flags on attachment: 157932 Committed r125396: <http://trac.webkit.org/changeset/125396> All reviewed patches have been landed. Closing bug. Lucas or Bill, could you restart the buildmaster again, please? (It seems automatic restart still doesn't work.) (In reply to comment #7) > Lucas or Bill, could you restart the buildmaster again, please? > (It seems automatic restart still doesn't work.) ping? It is very important to restart the master, because now all bots throw exception when somebody lands a new test without expected file. And are you planning to enable automatic master restarting after a master.cfg change? Restarted master but ran into this issue: 2012-08-14 11:27:16-0700 [-] Unhandled Error Traceback (most recent call last): File "/var/python/lib/python2.6/site-packages/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/var/python/lib/python2.6/site-packages/twisted/internet/defer.py", line 916, in gotResult _deferGenerator(g, deferred) File "/var/python/lib/python2.6/site-packages/twisted/internet/defer.py", line 891, in _deferGenerator result = g.next() File "/var/python/lib/python2.6/site-packages/buildbot/master.py", line 166, in startService self.configFileName) --- <exception caught here> --- File "/var/python/lib/python2.6/site-packages/buildbot/config.py", line 144, in loadConfig exec f in localDict File "/var/buildbot/master.cfg", line 921, in <module> loadBuilderConfig(c) File "/var/buildbot/master.cfg", line 847, in loadBuilderConfig c['slaves'] = [BuildSlave(slave['name'], passwords[slave['name']], max_builds=1) for slave in config['slaves']] exceptions.KeyError: u'indt-mountainlion' I've rolled back until we can investigate the below. I'm not sure why the build master isn't auto-restarting... maybe because it failed to start. Hopefully Bill can investigate then when he returns from vacation. I will also look into it as time allows. it looks like we needed a passwords update. I've fixed that and restarted the master. Things appear to be running now. It is fixed long time ago. |