Bug 93781

Summary: Remove "default" from CSS primitive value mapping switch statements
Product: WebKit Reporter: Bruno Abinader (history only) <bruno.abinader>
Component: CSSAssignee: Bruno Abinader (history only) <bruno.abinader>
Status: RESOLVED FIXED    
Severity: Enhancement CC: cmarcelo, igor.oliveira, jchaffraix, macpherson, menard, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 93921    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Bruno Abinader (history only)
Reported 2012-08-12 09:58:54 PDT
Removing the "default" switch case allows compile-time early warning check, as suggested by Julien in https://bugs.webkit.org/show_bug.cgi?id=90958#c35 .
Attachments
Patch (33.86 KB, patch)
2012-08-12 21:23 PDT, Bruno Abinader (history only) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bruno Abinader (history only)
Comment 1 2012-08-12 21:23:53 PDT
Created attachment 157918 [details] Patch Proposed patch.
WebKit Review Bot
Comment 2 2012-08-13 09:48:09 PDT
Comment on attachment 157918 [details] Patch Clearing flags on attachment: 157918 Committed r125425: <http://trac.webkit.org/changeset/125425>
WebKit Review Bot
Comment 3 2012-08-13 09:48:13 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 2012-08-13 18:29:53 PDT
Re-opened since this is blocked by 93921
Bruno Abinader (history only)
Comment 5 2012-08-17 09:13:02 PDT
Marking as fixed, as bug 93921 was marked as invalid (see link below for details): https://bugs.webkit.org/show_bug.cgi?id=93921#c2
Note You need to log in before you can comment on or make changes to this bug.