Bug 93781 - Remove "default" from CSS primitive value mapping switch statements
Summary: Remove "default" from CSS primitive value mapping switch statements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: Bruno Abinader (history only)
URL:
Keywords:
Depends on: 93921
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-12 09:58 PDT by Bruno Abinader (history only)
Modified: 2012-08-17 09:13 PDT (History)
7 users (show)

See Also:


Attachments
Patch (33.86 KB, patch)
2012-08-12 21:23 PDT, Bruno Abinader (history only)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Abinader (history only) 2012-08-12 09:58:54 PDT
Removing the "default" switch case allows compile-time early warning check, as suggested by Julien in https://bugs.webkit.org/show_bug.cgi?id=90958#c35 .
Comment 1 Bruno Abinader (history only) 2012-08-12 21:23:53 PDT
Created attachment 157918 [details]
Patch

Proposed patch.
Comment 2 WebKit Review Bot 2012-08-13 09:48:09 PDT
Comment on attachment 157918 [details]
Patch

Clearing flags on attachment: 157918

Committed r125425: <http://trac.webkit.org/changeset/125425>
Comment 3 WebKit Review Bot 2012-08-13 09:48:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2012-08-13 18:29:53 PDT
Re-opened since this is blocked by 93921
Comment 5 Bruno Abinader (history only) 2012-08-17 09:13:02 PDT
Marking as fixed, as bug 93921 was marked as invalid (see link below for details):
https://bugs.webkit.org/show_bug.cgi?id=93921#c2