Bug 93776

Summary: CSSComputedStyleDeclaration::cssText() should use StringBuilder
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: WebCore Misc.Assignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dglazkov, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Benjamin Poulain 2012-08-12 00:36:02 PDT 
String::append() is very inefficient when use like that.
Comment 1 Benjamin Poulain 2012-08-12 00:43:53 PDT 
Created attachment 157891 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-12 00:48:14 PDT 
Comment on attachment 157891 [details]
Patch

Attachment 157891 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13480440
Comment 3 Benjamin Poulain 2012-08-12 01:03:12 PDT 
Created attachment 157892 [details]
Patch
Comment 4 Eric Seidel (no email) 2012-08-12 02:38:30 PDT 
Comment on attachment 157892 [details]
Patch

Yup.  Do we have any microbenchmarks to show the speed win?
Comment 5 WebKit Review Bot 2012-08-12 03:37:30 PDT 
Comment on attachment 157892 [details]
Patch

Clearing flags on attachment: 157892

Committed r125367: <http://trac.webkit.org/changeset/125367>
Comment 6 WebKit Review Bot 2012-08-12 03:37:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Benjamin Poulain 2012-08-12 11:54:41 PDT 
> Yup.  Do we have any microbenchmarks to show the speed win?

Here is what I used to get the numbers: http://jsperf.com/csscomputedstyledeclaration-csstext