Bug 93776

Summary:

CSSComputedStyleDeclaration::cssText() should use StringBuilder

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

WebCore Misc.

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, dglazkov, macpherson, menard, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Benjamin Poulain

Reported 2012-08-12 00:36:02 PDT

String::append() is very inefficient when use like that.

Attachments
Patch (2.14 KB, patch) 2012-08-12 00:43 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (2.36 KB, patch) 2012-08-12 01:03 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2012-08-12 00:43:53 PDT

Created attachment 157891 [details] Patch

WebKit Review Bot

Comment 2 2012-08-12 00:48:14 PDT

Comment on attachment 157891 [details] Patch Attachment 157891 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13480440

Benjamin Poulain

Comment 3 2012-08-12 01:03:12 PDT

Created attachment 157892 [details] Patch

Eric Seidel (no email)

Comment 4 2012-08-12 02:38:30 PDT

Comment on attachment 157892 [details] Patch Yup. Do we have any microbenchmarks to show the speed win?

WebKit Review Bot

Comment 5 2012-08-12 03:37:30 PDT

Comment on attachment 157892 [details] Patch Clearing flags on attachment: 157892 Committed r125367: <http://trac.webkit.org/changeset/125367>

WebKit Review Bot

Comment 6 2012-08-12 03:37:35 PDT

All reviewed patches have been landed. Closing bug.

Benjamin Poulain

Comment 7 2012-08-12 11:54:41 PDT

> Yup. Do we have any microbenchmarks to show the speed win? Here is what I used to get the numbers: http://jsperf.com/csscomputedstyledeclaration-csstext

Note You need to log in before you can comment on or make changes to this bug.