Bug 93759

Summary: [chromium] FPS HUD bitmap contains random noise on the mac
Product: WebKit Reporter: Vangelis Kokkevis <vangelis>
Component: WebCore Misc.Assignee: Vangelis Kokkevis <vangelis>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, danakj, enne, eric, jamesr, reed, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch enne: review+, enne: commit-queue-

Description Vangelis Kokkevis 2012-08-10 19:48:40 PDT 
This is a result of not clearing the canvas used by the HUD before drawing into it.
Comment 1 Vangelis Kokkevis 2012-08-10 19:53:48 PDT 
Created attachment 157853 [details]
Patch
Comment 2 Adrienne Walker 2012-08-12 12:48:09 PDT 
Comment on attachment 157853 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157853&action=review

R=me, with one robustness suggestion.

> Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:99
> +    if (canvasSize.fWidth != bounds().width() || canvasSize.fHeight != bounds().height())

If bounds() are empty the first time through this function, it'll crash on a null m_hudCanvas below.  Maybe add a || !m_hudCanvas for safety?
Comment 3 Vangelis Kokkevis 2012-08-13 13:48:54 PDT 
Committed r125445: <http://trac.webkit.org/changeset/125445>