Bug 93737

Summary: Improved RuleData packing on some 32-bit platforms
Product: WebKit Reporter: Florin Malita <fmalita>
Component: CSSAssignee: Florin Malita <fmalita>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, kling, koivisto, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Florin Malita
Reported 2012-08-10 12:43:18 PDT
Certain 32-bit platforms use an 8-byte alignment for uint64_t (as exposed by the build breakage after http://trac.webkit.org/changeset/125294). To avoid wasting 4 bytes per object due to alignment, we can use two naturally-aligning unsigned integers instead.
Attachments
Patch (2.64 KB, patch)
2012-08-10 12:47 PDT, Florin Malita 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Florin Malita
Comment 1 2012-08-10 12:47:27 PDT
Created attachment 157795 [details] Patch
Andreas Kling
Comment 2 2012-08-10 14:08:02 PDT
Comment on attachment 157795 [details] Patch r=me, thanks for the fix!
WebKit Review Bot
Comment 3 2012-08-10 15:42:07 PDT
Comment on attachment 157795 [details] Patch Clearing flags on attachment: 157795 Committed r125333: <http://trac.webkit.org/changeset/125333>
WebKit Review Bot
Comment 4 2012-08-10 15:42:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.