Bug 93736

Summary: webarchive/ignore-noscript-if-scripting.html expected results should use .webarchive extension
Product: WebKit Reporter: Jon Lee <jonlee>
Component: Tools / TestsAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, beidson, dpranke, eric, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch none

Jon Lee
Reported 2012-08-10 12:36:22 PDT
Because the test uses dumpDOMAsWebArchive(), the expected results extension should be .webarchive instead of .txt.
Attachments
Patch (3.41 KB, patch)
2012-08-10 12:40 PDT, Jon Lee 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2012-08-10 12:36:45 PDT
<rdar://problem/12077654>
Jon Lee
Comment 2 2012-08-10 12:40:09 PDT
Created attachment 157793 [details] Patch
Eric Seidel (no email)
Comment 3 2012-08-11 02:39:05 PDT
I assume run-webkit-tests plays nice with .webarchive files?
Dirk Pranke
Comment 4 2012-08-11 11:34:16 PDT
It did the last time I checked.
Jon Lee
Comment 5 2012-08-11 12:07:07 PDT
The rest of that directory uses the .webarchive extension instead of the .txt extension. And yes rwt works with those files.
WebKit Review Bot
Comment 6 2012-08-11 12:41:59 PDT
Comment on attachment 157793 [details] Patch Clearing flags on attachment: 157793 Committed r125354: <http://trac.webkit.org/changeset/125354>
WebKit Review Bot
Comment 7 2012-08-11 12:42:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.