Bug 93728

Summary: NRWT crashes when DRT with --encode-binary crashes just before it dumps pixels
Product: WebKit Reporter: Xianzhu Wang <wangxianzhu>
Component: Tools / TestsAssignee: Xianzhu Wang <wangxianzhu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, webkit.review.bot
Priority: P2 Keywords: NRWT
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Xianzhu Wang
Reported 2012-08-10 10:15:49 PDT
If DRT running with --encode-binary crashes just before it dump pixels, block.content might be set to None (returned from self._server_process.read_stdout() at driver.py:421), then block.decode_content() will cause crash of NRWT in base64.b64decode() because self.content is None.
Attachments
Patch (1.42 KB, patch)
2012-08-10 10:22 PDT, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xianzhu Wang
Comment 1 2012-08-10 10:22:34 PDT
Created attachment 157756 [details] Patch
Xianzhu Wang
Comment 2 2012-08-10 11:47:41 PDT
Comment on attachment 157756 [details] Patch Sorry for the wrong component :)
WebKit Review Bot
Comment 3 2012-08-10 12:49:37 PDT
Comment on attachment 157756 [details] Patch Clearing flags on attachment: 157756 Committed r125316: <http://trac.webkit.org/changeset/125316>
WebKit Review Bot
Comment 4 2012-08-10 12:49:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.