Summary: | [WK2] Add getter for capture attribute of input element | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kihong Kwon <kihong.kwon> | ||||||||
Component: | WebKit2 | Assignee: | Kihong Kwon <kihong.kwon> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, eric, sam, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | Unspecified | ||||||||||
URL: | http://www.w3.org/TR/html-media-capture/ | ||||||||||
Attachments: |
|
Description
Kihong Kwon
2012-08-10 04:25:27 PDT
Created attachment 157709 [details]
Patch
Created attachment 157929 [details]
Patch
Comment on attachment 157929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157929&action=review > Source/WebKit2/Shared/WebOpenPanelParameters.cpp:66 > +#if ENABLE(MEDIA_CAPTURE) Why not include the whole function definition in the #ifdef ? > Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.cpp:53 > + return toCopiedAPI(toImpl(parametersRef)->capture()); Should we have a #if ENABLE(MEDIA_CAPTURE) and return 0 if undefined? > Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.h:46 > +WK_EXPORT WKStringRef WKOpenPanelParametersCopyCapture(WKOpenPanelParametersRef parametes); "parameters" Comment on attachment 157929 [details]
Patch
looks sane.
(In reply to comment #3) > (From update of attachment 157929 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157929&action=review > > > Source/WebKit2/Shared/WebOpenPanelParameters.cpp:66 > > +#if ENABLE(MEDIA_CAPTURE) > > Why not include the whole function definition in the #ifdef ? > > > Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.cpp:53 > > + return toCopiedAPI(toImpl(parametersRef)->capture()); > > Should we have a #if ENABLE(MEDIA_CAPTURE) and return 0 if undefined? > > > Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.h:46 > > +WK_EXPORT WKStringRef WKOpenPanelParametersCopyCapture(WKOpenPanelParametersRef parametes); > > "parameters" Done. Thanks! :) Created attachment 158226 [details]
Patch for landing.
Comment on attachment 158226 [details] Patch for landing. Clearing flags on attachment: 158226 Committed r125512: <http://trac.webkit.org/changeset/125512> All reviewed patches have been landed. Closing bug. |