Bug 93710

Summary: [WK2] Add getter for capture attribute of input element
Product: WebKit Reporter: Kihong Kwon <kihong.kwon>
Component: WebKit2Assignee: Kihong Kwon <kihong.kwon>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Unspecified   
URL: http://www.w3.org/TR/html-media-capture/
Attachments:
Description Flags
Patch
none
Patch
tonikitoo: review+
Patch for landing. none

Kihong Kwon
Reported 2012-08-10 04:25:27 PDT
Add getter for capture attribute to WKOpenPanelParameters to support Media Capture.
Attachments
Patch (4.76 KB, patch)
2012-08-10 05:02 PDT, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Patch (5.86 KB, patch)
2012-08-12 23:57 PDT, Kihong Kwon 		tonikitoo: review+
DetailsFormatted DiffDiff
Patch for landing. (5.51 KB, patch)
2012-08-13 23:08 PDT, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kihong Kwon
Comment 1 2012-08-10 05:02:12 PDT
Created attachment 157709 [details] Patch
Kihong Kwon
Comment 2 2012-08-12 23:57:19 PDT
Created attachment 157929 [details] Patch
Chris Dumez
Comment 3 2012-08-13 05:50:00 PDT
Comment on attachment 157929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157929&action=review > Source/WebKit2/Shared/WebOpenPanelParameters.cpp:66 > +#if ENABLE(MEDIA_CAPTURE) Why not include the whole function definition in the #ifdef ? > Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.cpp:53 > + return toCopiedAPI(toImpl(parametersRef)->capture()); Should we have a #if ENABLE(MEDIA_CAPTURE) and return 0 if undefined? > Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.h:46 > +WK_EXPORT WKStringRef WKOpenPanelParametersCopyCapture(WKOpenPanelParametersRef parametes); "parameters"
Antonio Gomes
Comment 4 2012-08-13 05:53:42 PDT
Comment on attachment 157929 [details] Patch looks sane.
Kihong Kwon
Comment 5 2012-08-13 22:20:35 PDT
(In reply to comment #3) > (From update of attachment 157929 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157929&action=review > > > Source/WebKit2/Shared/WebOpenPanelParameters.cpp:66 > > +#if ENABLE(MEDIA_CAPTURE) > > Why not include the whole function definition in the #ifdef ? > > > Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.cpp:53 > > + return toCopiedAPI(toImpl(parametersRef)->capture()); > > Should we have a #if ENABLE(MEDIA_CAPTURE) and return 0 if undefined? > > > Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.h:46 > > +WK_EXPORT WKStringRef WKOpenPanelParametersCopyCapture(WKOpenPanelParametersRef parametes); > > "parameters" Done. Thanks! :)
Kihong Kwon
Comment 6 2012-08-13 23:08:56 PDT
Created attachment 158226 [details] Patch for landing.
WebKit Review Bot
Comment 7 2012-08-14 00:18:09 PDT
Comment on attachment 158226 [details] Patch for landing. Clearing flags on attachment: 158226 Committed r125512: <http://trac.webkit.org/changeset/125512>
WebKit Review Bot
Comment 8 2012-08-14 00:18:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.