Bug 93699

Summary:

Web Inspector: add frame ids to TimeStamp, Time and TimeEnd records in Timeline

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Kosyakov <caseq>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+

Andrey Kosyakov

Reported 2012-08-10 01:19:42 PDT

This plumbs frame from Console to Timeline and uses it to add frameId fields to the following records: - TimeStamp - Time - TimeEnd

Attachments
Patch (16.52 KB, patch) 2012-08-10 01:31 PDT, Andrey Kosyakov	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrey Kosyakov

Comment 1 2012-08-10 01:31:43 PDT

Created attachment 157673 [details] Patch

Pavel Feldman

Comment 2 2012-08-10 03:06:32 PDT

What is the motivation behind this change?

Andrey Kosyakov

Comment 3 2012-08-10 03:10:23 PDT

(In reply to comment #2) > What is the motivation behind this change? Consistency with the rest of the timeline -- we try to provide frame ids for each record that is frame-specific. This will let clients filter only relevant frames.

Andrey Kosyakov

Comment 4 2012-08-10 06:44:21 PDT

Committed r125277: <http://trac.webkit.org/changeset/125277>

Note You need to log in before you can comment on or make changes to this bug.