Bug 93697

Summary: Web Inspector: console.timeStamp() marked are not shown in Timeline overview
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bmcquade, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Description Andrey Kosyakov 2012-08-10 00:45:55 PDT
0. Open Web Inspector, switch to the Timeline panel
1. Start timeline
2. Type console.timeStamp("foo") in console
3. Stop timeline
4. Note timestamp events appear in the detailed view
4. Note there are no orange vertical markers for the timestamp events in the time bars of either overview or detailed view.

This is a regression introduced at r119826 (http://trac.webkit.org/changeset/119826) -- timestamp events currently don't have a frame id. They probably should, but we should display timestamp for all frames anyway.
Comment 1 Andrey Kosyakov 2012-08-10 00:48:22 PDT
Created attachment 157657 [details]
Patch
Comment 2 Pavel Feldman 2012-08-10 00:52:38 PDT
Comment on attachment 157657 [details]
Patch

A test?
Comment 3 Andrey Kosyakov 2012-08-10 02:24:09 PDT
Created attachment 157689 [details]
Patch
Comment 4 Andrey Kosyakov 2012-08-10 06:27:00 PDT
Committed r125272: <http://trac.webkit.org/changeset/125272>