Summary: | Web Inspector: further ResourceLoader memory instrumentation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Yury Semikhatsky <yurys> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alph, apavlov, bweinstein, cmarcelo, gyuyoung.kim, japhet, joepeck, keishi, loislo, macpherson, menard, pfeldman, pmuellr, rakuco, rik, timothy, webkit.review.bot, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 87262 | ||||||
Attachments: |
|
Description
Yury Semikhatsky
2012-08-10 00:14:37 PDT
Created attachment 157652 [details]
Patch
Attachment 157652 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/loader/SubstituteData.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 157652 [details] Patch Attachment 157652 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13474203 (In reply to comment #3) > (From update of attachment 157652 [details]) > Attachment 157652 [details] did not pass mac-ews (mac): > Output: http://queues.webkit.org/results/13474203 Yep, SubstituteData::reportMemoryUsage should not be virtual. Fixed. Committed r125265: <http://trac.webkit.org/changeset/125265> |