Bug 93692 - Web Inspector: further ResourceLoader memory instrumentation
Summary: Web Inspector: further ResourceLoader memory instrumentation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks: 87262
  Show dependency treegraph
 
Reported: 2012-08-10 00:14 PDT by Yury Semikhatsky
Modified: 2012-08-10 02:43 PDT (History)
18 users (show)

See Also:


Attachments
Patch (18.73 KB, patch)
2012-08-10 00:27 PDT, Yury Semikhatsky
vsevik: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-08-10 00:14:37 PDT
There are some pieces of ResourceLoader and its descendants that are not yet instrumented.
Comment 1 Yury Semikhatsky 2012-08-10 00:27:53 PDT
Created attachment 157652 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-10 00:30:59 PDT
Attachment 157652 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/loader/SubstituteData.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2012-08-10 02:32:41 PDT
Comment on attachment 157652 [details]
Patch

Attachment 157652 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13474203
Comment 4 Yury Semikhatsky 2012-08-10 02:39:17 PDT
(In reply to comment #3)
> (From update of attachment 157652 [details])
> Attachment 157652 [details] did not pass mac-ews (mac):
> Output: http://queues.webkit.org/results/13474203

Yep, SubstituteData::reportMemoryUsage should not be virtual. Fixed.
Comment 5 Yury Semikhatsky 2012-08-10 02:43:31 PDT
Committed r125265: <http://trac.webkit.org/changeset/125265>