RESOLVED FIXED 93692
Web Inspector: further ResourceLoader memory instrumentation 
https://bugs.webkit.org/show_bug.cgi?id=93692
Summary Web Inspector: further ResourceLoader memory instrumentation
Yury Semikhatsky
Reported 2012-08-10 00:14:37 PDT
There are some pieces of ResourceLoader and its descendants that are not yet instrumented.
Attachments
Patch (18.73 KB, patch)
2012-08-10 00:27 PDT, Yury Semikhatsky 		vsevik: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-08-10 00:27:53 PDT
Created attachment 157652 [details] Patch
WebKit Review Bot
Comment 2 2012-08-10 00:30:59 PDT
Attachment 157652 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/loader/SubstituteData.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2012-08-10 02:32:41 PDT
Comment on attachment 157652 [details] Patch Attachment 157652 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13474203
Yury Semikhatsky
Comment 4 2012-08-10 02:39:17 PDT
(In reply to comment #3) > (From update of attachment 157652 [details]) > Attachment 157652 [details] did not pass mac-ews (mac): > Output: http://queues.webkit.org/results/13474203 Yep, SubstituteData::reportMemoryUsage should not be virtual. Fixed.
Yury Semikhatsky
Comment 5 2012-08-10 02:43:31 PDT
Committed r125265: <http://trac.webkit.org/changeset/125265>
Note You need to log in before you can comment on or make changes to this bug.