Summary: | Allow users to specify a different hover image for TextFieldDecorationElement | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Garrett Casto <gcasto> | ||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, guohui, jamesr, tkent, tkent+wkapi, webkit.review.bot, zysxqn | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Garrett Casto
2012-08-09 15:15:16 PDT
Created attachment 157559 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 157559 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157559&action=review The code change looks good. > Source/WebKit/chromium/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). Please replace this line with something or remove this line. r- because of this. Created attachment 157893 [details]
Patch
Comment on attachment 157893 [details]
Patch
ok
Created attachment 167632 [details]
Patch
So I just realized that this hasn't been submitted. The new patch has updated ChangeLog files, but everything else should be unchanged. Kent-san, would you mind sending this through the commit queue after review? Comment on attachment 167632 [details]
Patch
You needed to set "commit-queue ?" flag to ask to commit the patch.
Comment on attachment 167632 [details] Patch Clearing flags on attachment: 167632 Committed r130756: <http://trac.webkit.org/changeset/130756> All reviewed patches have been landed. Closing bug. |