Bug 93662

Summary: Allow users to specify a different hover image for TextFieldDecorationElement
Product: WebKit Reporter: Garrett Casto <gcasto>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, guohui, jamesr, tkent, tkent+wkapi, webkit.review.bot, zysxqn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Garrett Casto
Reported 2012-08-09 15:15:16 PDT
Allow users to specify a different hover image for TextFieldDecorationElement
Attachments
Patch (9.36 KB, patch)
2012-08-09 15:19 PDT, Garrett Casto 		no flags
DetailsFormatted DiffDiff
Patch (9.23 KB, patch)
2012-08-12 02:53 PDT, Garrett Casto 		no flags
DetailsFormatted DiffDiff
Patch (9.22 KB, patch)
2012-10-08 15:33 PDT, Garrett Casto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Garrett Casto
Comment 1 2012-08-09 15:19:08 PDT
Created attachment 157559 [details] Patch
WebKit Review Bot
Comment 2 2012-08-09 15:22:08 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Kent Tamura
Comment 3 2012-08-09 18:46:09 PDT
Comment on attachment 157559 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157559&action=review The code change looks good. > Source/WebKit/chromium/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). Please replace this line with something or remove this line. r- because of this.
Garrett Casto
Comment 4 2012-08-12 02:53:27 PDT
Created attachment 157893 [details] Patch
Kent Tamura
Comment 5 2012-08-12 06:22:41 PDT
Comment on attachment 157893 [details] Patch ok
Garrett Casto
Comment 6 2012-10-08 15:33:45 PDT
Created attachment 167632 [details] Patch
Garrett Casto
Comment 7 2012-10-08 15:42:10 PDT
So I just realized that this hasn't been submitted. The new patch has updated ChangeLog files, but everything else should be unchanged. Kent-san, would you mind sending this through the commit queue after review?
Kent Tamura
Comment 8 2012-10-09 06:37:33 PDT
Comment on attachment 167632 [details] Patch You needed to set "commit-queue ?" flag to ask to commit the patch.
WebKit Review Bot
Comment 9 2012-10-09 06:43:09 PDT
Comment on attachment 167632 [details] Patch Clearing flags on attachment: 167632 Committed r130756: <http://trac.webkit.org/changeset/130756>
WebKit Review Bot
Comment 10 2012-10-09 06:43:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.