Summary: | [WK2] Unskip tests requiring layoutTestController.dumpResourceResponseMIMETypes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||
Component: | WebKit2 | Assignee: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, ap, eric, kenneth, rniwa, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mikhail Pozdnyakov
2012-08-09 12:11:34 PDT
Created attachment 157511 [details]
patch
Unfortunately I do not have an opportunity to check that platform/mac/.. tests pass, so keep them skipped so far.
Tests 2 and 3 passed for me on Mac, but the first one failed: -example-dng.dng has MIME type application/octet-stream +example-dng.dng has MIME type image/x-adobe-dng This probably depends on whether one has Adobe software installed. It's not a very useful test overall, as it mostly reports what lower level OS components tell us, not about anything in WebKit. Comment on attachment 157511 [details] patch Rejecting attachment 157511 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/PerformanceTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13457937 The failure looks like a commit queue issue to me. Interesting. The regexp for "Unreviewed" must be too tight. Maybe something changed recently in the ChangeLog.py class. Or maybe this particular instance just got confused somehow. Someone pointed out on IRC that this is not a unique occurrence, see <https://bugs.webkit.org/show_bug.cgi?id=90959#c44>. The checkout got corrupted on one of the instances. Adam is fixing. Comment on attachment 157511 [details] patch Clearing flags on attachment: 157511 Committed r125215: <http://trac.webkit.org/changeset/125215> All reviewed patches have been landed. Closing bug. |