Bug 93614

Summary: [BlackBerry] Get rid of glCopyTexImage2D in Cavas and WebGL code paths
Product: WebKit Reporter: Arvid Nilsson <anilsson>
Component: WebKit BlackBerryAssignee: Arvid Nilsson <anilsson>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, fspacek, gyuyoung.kim, jnetterfield, levin+threading, manyoso, mifenton, noam, rakuco, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Arvid Nilsson
Reported 2012-08-09 05:50:13 PDT
PR 188472
Attachments
Patch (50.81 KB, patch)
2012-08-10 10:02 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
Patch (51.57 KB, patch)
2012-08-12 15:41 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
Patch (51.65 KB, patch)
2012-08-14 06:28 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Arvid Nilsson
Comment 1 2012-08-10 10:02:03 PDT
Created attachment 157753 [details] Patch
George Staikos
Comment 2 2012-08-10 17:39:38 PDT
Comment on attachment 157753 [details] Patch you need to rebase this.
Arvid Nilsson
Comment 3 2012-08-11 02:32:16 PDT
Hmm, it's rebased to most recent in our forked repo...
Arvid Nilsson
Comment 4 2012-08-12 15:40:01 PDT
Aha, the merge conflict is because we haven't upstreamed the fix for https://bugs.webkit.org/show_bug.cgi?id=86483 (PR #153047) yet
Arvid Nilsson
Comment 5 2012-08-12 15:41:18 PDT
Created attachment 157912 [details] Patch
Arvid Nilsson
Comment 6 2012-08-12 15:41:42 PDT
(In reply to comment #2) > (From update of attachment 157753 [details]) > you need to rebase this. Here's a patch that does apply to upstream
Antonio Gomes
Comment 7 2012-08-13 12:53:22 PDT
Comment on attachment 157912 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157912&action=review > Source/WebCore/platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:96 > + // If the image is still with us, it was never destroyed by the EGLImageLayerWebKitThread lacks a "." > Source/WebCore/platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:97 > + if (m_image) { early return preferable
Arvid Nilsson
Comment 8 2012-08-14 06:00:54 PDT
(In reply to comment #7) > (From update of attachment 157912 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157912&action=review > > > Source/WebCore/platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:96 > > + // If the image is still with us, it was never destroyed by the EGLImageLayerWebKitThread > > lacks a "." > > > Source/WebCore/platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:97 > > + if (m_image) { > > early return preferable Will fix!
Arvid Nilsson
Comment 9 2012-08-14 06:28:37 PDT
Created attachment 158314 [details] Patch
Arvid Nilsson
Comment 10 2012-08-14 06:31:12 PDT
Comment on attachment 158314 [details] Patch This patch is changed only to adress Antonio's review comments, so I'm just gonna cq+ it.
WebKit Review Bot
Comment 11 2012-08-14 07:34:00 PDT
Comment on attachment 158314 [details] Patch Clearing flags on attachment: 158314 Committed r125563: <http://trac.webkit.org/changeset/125563>
WebKit Review Bot
Comment 12 2012-08-14 07:34:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.