Bug 93613

Summary: Remove custom bindings from WaveShaperNode.
Product: WebKit Reporter: Vineet Chaudhary (vineetc) <code.vineet>
Component: New BugsAssignee: Vineet Chaudhary (vineetc) <code.vineet>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, crogers, eric.carlson, feature-media-reviews, gyuyoung.kim, haraken, japhet, ojan, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch_for_review none

Vineet Chaudhary (vineetc)
Reported 2012-08-09 05:38:06 PDT
We should remove custom bindings as CodeGenerator uses UNUSED_PARAM macro. This was introduced in r91281.
Attachments
Patch (8.37 KB, patch)
2012-08-09 05:41 PDT, Vineet Chaudhary (vineetc) 		no flags
DetailsFormatted DiffDiff
patch_for_review (19.13 KB, patch)
2012-08-10 02:38 PDT, Vineet Chaudhary (vineetc) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vineet Chaudhary (vineetc)
Comment 1 2012-08-09 05:41:24 PDT
Created attachment 157453 [details] Patch
Vineet Chaudhary (vineetc)
Comment 2 2012-08-10 02:38:34 PDT
Created attachment 157691 [details] patch_for_review Updated patch for review.
Kentaro Hara
Comment 3 2012-08-10 04:59:00 PDT
Comment on attachment 157691 [details] patch_for_review Good refactoring!
WebKit Review Bot
Comment 4 2012-08-10 09:49:13 PDT
Comment on attachment 157691 [details] patch_for_review Clearing flags on attachment: 157691 Committed r125293: <http://trac.webkit.org/changeset/125293>
WebKit Review Bot
Comment 5 2012-08-10 09:49:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.