Bug 93562

Summary: Parsing "all" for -webkit-user-select
Product: WebKit Reporter: Alice Cheng <alice_cheng>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cmarcelo, eric, gustavo, macpherson, menard, philn, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91912    
Attachments:
Description Flags
patch
none
patch
none
patch for buildbot
none
Patch for style bot none

Alice Cheng
Reported 2012-08-08 17:49:58 PDT
This is the first part for https://bugs.webkit.org/show_bug.cgi?id=91912 Parse the new "all" value for -webkit-user-select
Attachments
patch (6.42 KB, patch)
2012-08-08 17:52 PDT, Alice Cheng 		no flags
DetailsFormatted DiffDiff
patch (6.44 KB, patch)
2012-08-08 18:13 PDT, Alice Cheng 		no flags
DetailsFormatted DiffDiff
patch for buildbot (8.15 KB, patch)
2012-08-10 09:18 PDT, Alice Cheng 		no flags
DetailsFormatted DiffDiff
Patch for style bot (8.15 KB, patch)
2012-08-10 12:21 PDT, Alice Cheng 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alice Cheng
Comment 1 2012-08-08 17:52:10 PDT
Created attachment 157353 [details] patch This patch correctly parses the new value "all" for -webkit-user-select
Alice Cheng
Comment 2 2012-08-08 18:13:12 PDT
Created attachment 157356 [details] patch Previous patch was malformed. Sorry about it.
Alice Cheng
Comment 3 2012-08-10 09:18:07 PDT
Created attachment 157744 [details] patch for buildbot modified the ambiguous enum in gtk/webkitwebview.cpp
WebKit Review Bot
Comment 4 2012-08-10 09:20:22 PDT
Attachment 157744 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/edit..." exit_code: 1 Source/WebCore/rendering/style/StyleRareInheritedData.h:92: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alice Cheng
Comment 5 2012-08-10 12:21:57 PDT
Created attachment 157786 [details] Patch for style bot fixed the style
WebKit Review Bot
Comment 6 2012-08-10 14:48:19 PDT
Comment on attachment 157786 [details] Patch for style bot Clearing flags on attachment: 157786 Committed r125330: <http://trac.webkit.org/changeset/125330>
WebKit Review Bot
Comment 7 2012-08-10 14:48:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.