Bug 93537

Summary: update bot parsing of new-run-webkit-tests' output
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: lforschler, ojan, ossy, rniwa, wsiegrist
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 93789    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Dirk Pranke
Reported 2012-08-08 15:29:19 PDT
update bot parsing of new-run-webkit-tests' output
Attachments
Patch (2.07 KB, patch)
2012-08-08 15:33 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-08-08 15:33:07 PDT
Created attachment 157312 [details] Patch
Dirk Pranke
Comment 2 2012-08-08 15:34:09 PDT
Ossy, does this look good to you? If so, can you land it (or cq+ it) and update your bots as well and let me know when I can re-land the output changes? Thanks!
Ryosuke Niwa
Comment 3 2012-08-08 15:37:17 PDT
Comment on attachment 157312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157312&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:352 > - ('flakes', re.compile(r'Unexpected flakiness.+:?\s*\((\d+)\)')), > + ('flakes', re.compile(r'[Uu]nexpected flakiness.+:?\s*\((\d+)\)')), Why don't we just ignore cases?
Ryosuke Niwa
Comment 4 2012-08-08 15:37:38 PDT
Comment on attachment 157312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157312&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:355 > + ('missing results', re.compile(r'(no expected results found|missing results)\s*:\s+\((\d+)\)')), > + ('failures', re.compile(r'Regressions: [Uu]nexpected.+:?\s*\((\d+)\)')), Ditto.
Dirk Pranke
Comment 5 2012-08-08 15:44:18 PDT
Comment on attachment 157312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157312&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:355 >> + ('failures', re.compile(r'Regressions: [Uu]nexpected.+:?\s*\((\d+)\)')), > > Ditto. we could, but I'll leave things tight for now. ideally we'd just get a block of json to read and not do this hand-parsing.
Csaba Osztrogonác
Comment 6 2012-08-08 22:50:39 PDT
Comment on attachment 157312 [details] Patch Clearing flags on attachment: 157312 Committed r125153: <http://trac.webkit.org/changeset/125153>
Csaba Osztrogonác
Comment 7 2012-08-08 22:50:45 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 8 2012-08-08 22:52:59 PDT
It seems automatic master restart still doesn't work. :( Bill or Lucas, could you restart/reconfigure the master, please?
Csaba Osztrogonác
Comment 9 2012-08-09 14:58:33 PDT
Reopen until master restart. Lucas, please close it after restarting the master. Thanks in advance.
Lucas Forschler
Comment 10 2012-08-10 04:11:40 PDT
Sorry for the delay. I've manually updated the master and restarted it. Please verify that things are working as expected and let me know.
Note You need to log in before you can comment on or make changes to this bug.