Bug 93526

Summary:

Avoid backing store on layers created for CoreAnimation plugins

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, dino, eric, simon.fraser, thorton, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	dino: review+

Description Simon Fraser (smfr) 2012-08-08 14:29:06 PDT

Avoid backing store on layers created for CoreAnimation plugins

Comment 1 Simon Fraser (smfr) 2012-08-08 14:31:36 PDT

Created attachment 157299 [details]
Patch

Comment 2 Simon Fraser (smfr) 2012-08-08 14:32:26 PDT

<rdar://problem/12052828>

Comment 3 Dean Jackson 2012-08-08 15:02:03 PDT

Comment on attachment 157299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157299&action=review

> Source/WebCore/ChangeLog:8
> +        We create a compositing layer for <emebed> objects whose plug-in supports

typo emembedebed

Comment 4 Simon Fraser (smfr) 2012-08-08 15:17:57 PDT

http://trac.webkit.org/changeset/125101

Comment 5 Andrew Scherkus 2012-08-08 15:28:37 PDT

Committed r125102: <http://trac.webkit.org/changeset/125102>

Comment 6 Darin Adler 2012-08-08 17:25:36 PDT

Comment on attachment 157299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157299&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:913
> +    if (renderObject->isReplaced() && !isCompositedPlugin(renderObject))
> +            return false;

Wrong indentation on this return statement.