Summary: | Horizontal scrollbar appears in the month-year selector of input[type=date] | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kevin Ellis <kevers> | ||||
Component: | New Bugs | Assignee: | Kevin Ellis <kevers> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | keishi, rjkroege, tkent, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Kevin Ellis
2012-08-08 13:54:44 PDT
Created attachment 157289 [details]
Patch
Horizontal scrollbar reported on Chrome with a Japanese UI on Windows 7. Comment on attachment 157289 [details]
Patch
LGTM.
FYI: WebCore/Resources/colorSuggestionPicker.js has a code to get the scrollbar width. We had better share some code with it.
Several other functions could be shared between colorSuggestionPicker.js and calendarPicker.js as well such as $() bind() and createElement(). OK with a separate patch to consolidate the common utility functions into a separate js file? > OK with a separate patch to consolidate the common utility functions into a separate js file?
Yes. It's not your responsibility. The patch in this bug is ok as is.
Comment on attachment 157289 [details] Patch Clearing flags on attachment: 157289 Committed r125289: <http://trac.webkit.org/changeset/125289> All reviewed patches have been landed. Closing bug. |