Bug 93510

Summary: Implement new synchronized audio I/O render method in chromium
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Chris Rogers <crogers>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kbr: review+

Chris Rogers
Reported 2012-08-08 13:12:40 PDT
Implement new synchronized audio I/O render method in chromium
Attachments
Patch (6.83 KB, patch)
2012-08-08 13:17 PDT, Chris Rogers 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2012-08-08 13:17:56 PDT
Created attachment 157277 [details] Patch
Kenneth Russell
Comment 2 2012-08-13 17:43:41 PDT
Comment on attachment 157277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157277&action=review Looks generally fine -- r=me -- but a couple of comments which you can feel free to ignore if they're off base. > Source/WebKit/chromium/src/AudioDestinationChromium.cpp:92 > + AudioBus silence(2, renderBufferSize); 2? Really? Why not numberOfChannels? > Source/WebKit/chromium/src/AudioDestinationChromium.cpp:139 > + AudioBus wrapperBus(2, numberOfFrames, false); 2 again? If this is a temporary hack until this code is generalized then add a FIXME. > Source/WebKit/chromium/src/AudioDestinationChromium.cpp:180 > + // Render using the Web Audio engine. Does this comment add any value?
Chris Rogers
Comment 3 2012-08-14 16:17:25 PDT
Committed r125618: <http://trac.webkit.org/changeset/125618>
Note You need to log in before you can comment on or make changes to this bug.