| Summary: | Implement new synchronized audio I/O render method in chromium | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Rogers <crogers> | ||||
| Component: | New Bugs | Assignee: | Chris Rogers <crogers> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric.carlson, feature-media-reviews, kbr, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Chris Rogers
2012-08-08 13:12:40 PDT
Created attachment 157277 [details]
Patch
Comment on attachment 157277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157277&action=review Looks generally fine -- r=me -- but a couple of comments which you can feel free to ignore if they're off base. > Source/WebKit/chromium/src/AudioDestinationChromium.cpp:92 > + AudioBus silence(2, renderBufferSize); 2? Really? Why not numberOfChannels? > Source/WebKit/chromium/src/AudioDestinationChromium.cpp:139 > + AudioBus wrapperBus(2, numberOfFrames, false); 2 again? If this is a temporary hack until this code is generalized then add a FIXME. > Source/WebKit/chromium/src/AudioDestinationChromium.cpp:180 > + // Render using the Web Audio engine. Does this comment add any value? Committed r125618: <http://trac.webkit.org/changeset/125618> |