Summary: | Rename two methods of BitmapImage in order to clarify the intention: frameDurationAtIndex() and frameIsCompleteAtIndex(). | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dongseong Hwang <dongseong.hwang> | ||||||||||
Component: | Images | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | UNCONFIRMED --- | ||||||||||||
Severity: | Normal | CC: | dglazkov, gustavo, hclam, senorblanco, skyul, webkit.review.bot, xan.lopez | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 90375, 93467 | ||||||||||||
Attachments: |
|
Description
Dongseong Hwang
2012-08-08 04:58:25 PDT
Created attachment 157184 [details]
Patch
Comment on attachment 157184 [details] Patch Attachment 157184 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13457443 Comment on attachment 157184 [details] Patch Attachment 157184 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13462063 Comment on attachment 157184 [details] Patch Attachment 157184 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13461133 Comment on attachment 157184 [details] Patch Attachment 157184 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13458238 Comment on attachment 157184 [details] Patch Attachment 157184 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13454493 This patch was implemented based on Bug 93171, so all build bots failed. I'll post this patch again after landing Bug 93171. Created attachment 157403 [details]
Patch
(In reply to comment #8) > Created an attachment (id=157403) [details] > Patch The first patch renamed two methods of ImageSource as well as two methods of BitmapImage. But this patch renamed only those of BitmapImage, because Bug 93467 prevents clients, except for BitmapImage, from using two methods of ImageSource. Comment on attachment 157403 [details] Patch Attachment 157403 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13458598 Comment on attachment 157403 [details] Patch Attachment 157403 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13462388 Created attachment 157409 [details]
Patch
Created attachment 158718 [details]
Patch
(In reply to comment #13) > Created an attachment (id=158718) [details] > Patch Rebased to the upstream Comment on attachment 158718 [details]
Patch
Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
|