Bug 93457

Summary: [WK2] [WTR] Refactoring: LayoutTestController::shouldDumpProgressFinishedCallback() should be const
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit2Assignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, kenneth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Mikhail Pozdnyakov 2012-08-08 02:24:24 PDT
LayoutTestController::shouldDumpProgressFinishedCallback() should be const.
Comment 1 Mikhail Pozdnyakov 2012-08-08 02:27:40 PDT
Created attachment 157163 [details]
patch
Comment 2 Chris Dumez 2012-08-08 02:33:07 PDT
Comment on attachment 157163 [details]
patch

LGTM.
Comment 3 Csaba Osztrogon√°c 2012-08-08 02:37:44 PDT
Comment on attachment 157163 [details]
patch

rs=me
Comment 4 WebKit Review Bot 2012-08-08 04:20:56 PDT
Comment on attachment 157163 [details]
patch

Clearing flags on attachment: 157163

Committed r125019: <http://trac.webkit.org/changeset/125019>
Comment 5 WebKit Review Bot 2012-08-08 04:21:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexey Proskuryakov 2012-08-08 10:30:53 PDT
In the future, please provide rationale for changes. One can only guess why you needed this: 

- No actual impact, just for consistency with other getters?
- Because this was breaking build for some platforms?
- Because your personal preferred coding style is to have const on all methods that could have it?

Also, is this some code that you just added, and are cleaning it up, or a long standing issue? That's also useful information, and others should not resort to svn blame to get it.