Summary: | [NRWT] REGRESSION(r124967): New tests without expected results handled as failures | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | Tools / Tests | Assignee: | Csaba Osztrogonác <ossy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dpranke, ojan, ossy, rniwa, webkit.review.bot | ||||
Priority: | P2 | Keywords: | NRWT | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 88702 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2012-08-07 22:17:27 PDT
Yes, it is so similar bug ... The new "Regressions: Unexpected missing results" match for the regexp of failures .. Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg ----------------------------------------------------------- ... def _parseNewRunWebKitTestsOutput(self, logText): incorrectLayoutLines = [] expressions = [ ('flakes', re.compile(r'Unexpected flakiness.+:?\s*\((\d+)\)')), ('new passes', re.compile(r'Expected to .+, but passed:\s+\((\d+)\)')), ('missing results', re.compile(r'no expected results found\s*:\s+\((\d+)\)')), ('failures', re.compile(r'Regressions: Unexpected.+:?\s*\((\d+)\)')), ] testFailures = {} ... Created attachment 157115 [details]
Patch
If we really want to change the output of NRWT, please make it sync with master.cfg changes. And please contact with Lucas and/or Bill to restart the master after the change to ensure correct behaviour. And please ping me, because I have to make similar changes in master.cfg of build.webkit.sed.hu. (Maybe you have to make similar changes in master.cfg of build.chromium.org too) Comment on attachment 157115 [details] Patch Clearing flags on attachment: 157115 Committed r124988: <http://trac.webkit.org/changeset/124988> All reviewed patches have been landed. Closing bug. Comment on attachment 157115 [details]
Patch
Sorry! (again).
(In reply to comment #6) > (From update of attachment 157115 [details]) > Sorry! (again). To be clear(er), it was not actually my intention to change the output that the bot would be seeing :(. I did not mean to break the parser (or require changes to the parser). not problem ;) I didn't notice that the order of two messages changed (printed for each test, printed at the end), so my fix wasn't correct. I fixed it - https://trac.webkit.org/changeset/124994 |