Summary: | Add support for String initialization from literal to WTFString | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
Component: | Web Template Framework | Assignee: | Benjamin Poulain <benjamin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, darin, dglazkov, gustavo, philn, webkit.review.bot, xan.lopez | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 93402 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Benjamin Poulain
2012-08-07 19:45:43 PDT
Created attachment 157091 [details]
Patch
Attachment 157091 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1
Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:36: Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b) [readability/check] [2]
Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:43: Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b) [readability/check] [2]
Total errors found: 2 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 157091 [details] Patch Attachment 157091 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13450687 Comment on attachment 157091 [details] Patch Attachment 157091 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13457284 Comment on attachment 157091 [details] Patch Attachment 157091 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13453469 Comment on attachment 157091 [details] Patch Attachment 157091 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13457285 Comment on attachment 157091 [details] Patch Attachment 157091 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13461009 Comment on attachment 157091 [details] Patch Attachment 157091 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13457608 Created attachment 157385 [details]
Patch
Attachment 157385 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1
Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:36: Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b) [readability/check] [2]
Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:43: Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b) [readability/check] [2]
Total errors found: 2 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 157385 [details] Patch Clearing flags on attachment: 157385 Committed r125320: <http://trac.webkit.org/changeset/125320> All reviewed patches have been landed. Closing bug. |