Bug 93426

Summary: Add support for String initialization from literal to WTFString
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Web Template FrameworkAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, darin, dglazkov, gustavo, philn, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 93402    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Benjamin Poulain
Reported 2012-08-07 19:45:43 PDT
Add support for String initialization from literal to WTFString
Attachments
Patch (15.83 KB, patch)
2012-08-07 20:01 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (15.73 KB, patch)
2012-08-08 22:10 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-08-07 20:01:52 PDT
Created attachment 157091 [details] Patch
WebKit Review Bot
Comment 2 2012-08-07 20:05:05 PDT
Attachment 157091 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1 Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:36: Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b) [readability/check] [2] Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:43: Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b) [readability/check] [2] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2012-08-07 20:25:53 PDT
Comment on attachment 157091 [details] Patch Attachment 157091 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13450687
Build Bot
Comment 4 2012-08-07 20:28:57 PDT
Comment on attachment 157091 [details] Patch Attachment 157091 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13457284
WebKit Review Bot
Comment 5 2012-08-07 20:29:45 PDT
Comment on attachment 157091 [details] Patch Attachment 157091 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13453469
Early Warning System Bot
Comment 6 2012-08-07 20:29:56 PDT
Comment on attachment 157091 [details] Patch Attachment 157091 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13457285
Gyuyoung Kim
Comment 7 2012-08-07 22:37:51 PDT
Comment on attachment 157091 [details] Patch Attachment 157091 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13461009
Build Bot
Comment 8 2012-08-08 15:10:48 PDT
Comment on attachment 157091 [details] Patch Attachment 157091 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13457608
Benjamin Poulain
Comment 9 2012-08-08 22:10:30 PDT
Created attachment 157385 [details] Patch
WebKit Review Bot
Comment 10 2012-08-08 22:45:16 PDT
Attachment 157385 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1 Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:36: Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b) [readability/check] [2] Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:43: Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b) [readability/check] [2] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 11 2012-08-10 13:18:20 PDT
Comment on attachment 157385 [details] Patch Clearing flags on attachment: 157385 Committed r125320: <http://trac.webkit.org/changeset/125320>
Benjamin Poulain
Comment 12 2012-08-10 13:18:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.