Bug 93391

Summary: [chromium] Move WebCompositor interface into Platform API
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, enne, fishd, nduca, piman, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review+

James Robinson
Reported 2012-08-07 14:02:12 PDT
[chromium] Move WebCompositor interface into Platform AP
Attachments
Patch (38.81 KB, patch)
2012-08-07 14:06 PDT, James Robinson 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-08-07 14:06:04 PDT
Created attachment 156996 [details] Patch
James Robinson
Comment 2 2012-08-07 14:08:38 PDT
There are two motivations behind this: 1.) I'd like to add the "am I in threaded mode" getter to WebCompositor so that we don't have code all over WebCore depending on CCProxy to get at this data 2.) With this patch, users of the compositor can depend only on the Platform API instead of depending on the client API just for compositor initialization (which is a concern that goes away with GTFO, but is still nice in the short term).
WebKit Review Bot
Comment 3 2012-08-07 14:09:43 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 4 2012-08-07 14:15:22 PDT
Comment on attachment 156996 [details] Patch make sense.
James Robinson
Comment 5 2012-08-07 14:23:50 PDT
Committed r124917: <http://trac.webkit.org/changeset/124917>
Note You need to log in before you can comment on or make changes to this bug.