Bug 93377

Summary: Web Inspector: store last evaluation result in $_
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, homakov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Pavel Feldman 2012-08-07 11:15:51 PDT
This would allow referencing the last eval result from console.
Comment 1 Pavel Feldman 2012-08-07 11:18:08 PDT
Created attachment 156962 [details]
Patch
Comment 2 Paul Irish 2012-08-07 11:22:36 PDT
*** Bug 87038 has been marked as a duplicate of this bug. ***
Comment 3 Vsevolod Vlasov 2012-08-07 23:16:15 PDT
Comment on attachment 156962 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156962&action=review

Shouldn't we agree with firebug folks on this particular name for such a variable?

> Source/WebCore/inspector/InjectedScriptSource.js:805
> +    this.$_ = injectedScript._lastResult;

nit: I'd use __defineGetter__ instead.
Comment 4 WebKit Review Bot 2012-08-08 06:21:56 PDT
Comment on attachment 156962 [details]
Patch

Clearing flags on attachment: 156962

Committed r125033: <http://trac.webkit.org/changeset/125033>
Comment 5 WebKit Review Bot 2012-08-08 06:22:00 PDT
All reviewed patches have been landed.  Closing bug.