Bug 93364

Summary: REGRESSION(r124865): It broke the ARM Chromium build
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Blocker CC: haraken, jsbell, ossy, webkit.review.bot, xingnan.wang
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 91813    
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2012-08-07 06:56:51 PDT
http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Chromium%20Release%20%28Build%29/builds/6774 cc1plus: warnings being treated as errors Source/WebKit/chromium/tests/IDBLevelDBCodingTest.cpp:208: error: integer constant is too large for 'long' type make: *** [out/Release/obj.target/webkit_unit_tests/Source/WebKit/chromium/tests/IDBLevelDBCodingTest.o] Error 1 make: *** Waiting for unfinished jobs....
Attachments
Patch (1.67 KB, patch)
2012-08-07 08:48 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (1.61 KB, patch)
2012-08-07 08:50 PDT, Xingnan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-08-07 08:48:46 PDT
Created attachment 156950 [details] Patch
Xingnan Wang
Comment 2 2012-08-07 08:50:01 PDT
Created attachment 156952 [details] Patch
Xingnan Wang
Comment 3 2012-08-07 08:53:52 PDT
(In reply to comment #2) > Created an attachment (id=156952) [details] > Patch Opps, thank Joshua, ignore mine.
Joshua Bell
Comment 4 2012-08-07 08:55:05 PDT
(In reply to comment #3) > (In reply to comment #2) > > Created an attachment (id=156952) [details] [details] > > Patch > > Opps, thank Joshua, ignore mine. Thought you'd be asleep. :) No worries, the patches are identical apart from ChangeLogs.
Csaba Osztrogonác
Comment 5 2012-08-07 08:57:35 PDT
Comment on attachment 156950 [details] Patch rs=me, the faster patch won. :) Thanks for the fix.
Csaba Osztrogonác
Comment 6 2012-08-07 11:56:10 PDT
Comment on attachment 156950 [details] Patch Clearing flags on attachment: 156950 Committed r124902: <http://trac.webkit.org/changeset/124902>
Csaba Osztrogonác
Comment 7 2012-08-07 11:56:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.