Bug 93347

Summary: showNodePath should show the age of ShadowRoot
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: morrita, shinyak, tasak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Shinya Kawanaka
Reported 2012-08-07 02:26:55 PDT
We would like to know the age of ShadowRoot. I mean, the youngest is 0, the older shadow root of the youngest shadow root is 1.
Attachments
Patch (1.79 KB, patch)
2012-08-07 22:25 PDT, Takashi Sakamoto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Takashi Sakamoto
Comment 1 2012-08-07 22:25:12 PDT
Created attachment 157113 [details] Patch
Shinya Kawanaka
Comment 2 2012-08-07 23:00:07 PDT
Comment on attachment 157113 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157113&action=review > Source/WebCore/dom/Node.cpp:2135 > + for (ShadowRoot* shadowRoot = oldestShadowRootFor(toShadowRoot(node)->host()); shadowRoot && shadowRoot != node; shadowRoot = shadowRoot->youngerShadowRoot()) In this patch, the oldest shadow root is 0 and its younger shadow root is 1. Right? I'm OK if it's consistent though.
WebKit Review Bot
Comment 3 2012-08-08 00:03:08 PDT
Comment on attachment 157113 [details] Patch Clearing flags on attachment: 157113 Committed r125000: <http://trac.webkit.org/changeset/125000>
WebKit Review Bot
Comment 4 2012-08-08 00:03:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.