Bug 93346

Summary: REGRESSION(r124800): It broke NRWT result parsing of build.webkit.org
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Blocker CC: abarth, dpranke, ojan, ossy, tmpsantos, webkit.review.bot
Priority: P1 Keywords: NRWT
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 93026    
Attachments:
Description Flags
Patch none

Description Csaba Osztrogonác 2012-08-07 01:55:56 PDT 
Fix is coming soon.
Comment 1 Csaba Osztrogonác 2012-08-07 02:04:24 PDT 
Created attachment 156896 [details]
Patch
Comment 2 Csaba Osztrogonác 2012-08-07 02:07:16 PDT 
That's why we need "Unexpected" instead of "unexpected" in the result:

Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
-----------------------------------------------------------
...

    def _parseNewRunWebKitTestsOutput(self, logText):
        incorrectLayoutLines = []
        expressions = [
            ('flakes', re.compile(r'Unexpected flakiness.+:?\s*\((\d+)\)')),
            ('new passes', re.compile(r'Expected to .+, but passed:\s+\((\d+)\)')),
            ('missing results', re.compile(r'no expected results found\s*:\s+\((\d+)\)')),
            ('failures', re.compile(r'Regressions: Unexpected.+:?\s*\((\d+)\)')),
        ]
        testFailures = {}
...
Comment 3 Simon Hausmann 2012-08-07 02:10:29 PDT 
Comment on attachment 156896 [details]
Patch

rs=me
Comment 4 Simon Hausmann 2012-08-07 02:10:49 PDT 
Comment on attachment 156896 [details]
Patch

rs=me
Comment 5 Csaba Osztrogonác 2012-08-07 02:15:38 PDT 
Committed r124870: <http://trac.webkit.org/changeset/124870>