Summary: | [V8] Remove a bunch of Persistent::New()s on setJSWrapperForXXXObject() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||
Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric.carlson, feature-media-reviews, japhet, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 93095 | ||||||
Attachments: |
|
Description
Kentaro Hara
2012-08-07 00:03:59 PDT
Created attachment 156883 [details]
Patch
Comment on attachment 156883 [details]
Patch
Ok. Are you sure you got them all? If we missed one, we'll create a leak.
(In reply to comment #2) > (From update of attachment 156883 [details]) > Ok. Are you sure you got them all? If we missed one, we'll create a leak. Looks OK. Let me land the patch tomorrow. $ grep -r setJSWrapper WebCore/bindings/v8/* | grep Persistent V8DOMWrapper.cpp:v8::Persistent<v8::Object> V8DOMWrapper::setJSWrapperForDOMNode(PassRefPtr<Node> node, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate) V8DOMWrapper.cpp:v8::Persistent<v8::Object> V8DOMWrapper::setJSWrapperForActiveDOMNode(PassRefPtr<Node> node, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate) V8DOMWrapper.h: static v8::Persistent<v8::Object> setJSWrapperForDOMObject(PassRefPtr<T>, v8::Handle<v8::Object>, v8::Isolate* = 0); V8DOMWrapper.h: static v8::Persistent<v8::Object> setJSWrapperForActiveDOMObject(PassRefPtr<T>, v8::Handle<v8::Object>, v8::Isolate* = 0); V8DOMWrapper.h: static v8::Persistent<v8::Object> setJSWrapperForDOMNode(PassRefPtr<Node>, v8::Handle<v8::Object>, v8::Isolate* = 0); V8DOMWrapper.h: static v8::Persistent<v8::Object> setJSWrapperForActiveDOMNode(PassRefPtr<Node>, v8::Handle<v8::Object>, v8::Isolate* = 0); V8DOMWrapper.h: v8::Persistent<v8::Object> V8DOMWrapper::setJSWrapperForDOMObject(PassRefPtr<T> object, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate) V8DOMWrapper.h: v8::Persistent<v8::Object> V8DOMWrapper::setJSWrapperForActiveDOMObject(PassRefPtr<T> object, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate) custom/V8ArrayBufferViewCustom.h: v8::Persistent<v8::Object> wrapperHandle = V8DOMWrapper::setJSWrapperForDOMObject(array.release(), wrapper); custom/V8ArrayBufferViewCustom.h: v8::Persistent<v8::Object> wrapperHandle = V8DOMWrapper::setJSWrapperForDOMObject(array.release(), wrapper); Comment on attachment 156883 [details] Patch Clearing flags on attachment: 156883 Committed r124968: <http://trac.webkit.org/changeset/124968> All reviewed patches have been landed. Closing bug. |