Bug 93319

Summary: [chromium] Remove lingering unwrap<>() calls in GraphicsLayerChromium.cpp
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, dglazkov, enne, fishd, piman, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

James Robinson
Reported 2012-08-06 18:50:11 PDT
[chromium] Remove lingering unwrap<>() calls in GraphicsLayerChromium.cpp
Attachments
Patch (15.80 KB, patch)
2012-08-06 18:51 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-08-06 18:51:24 PDT
Created attachment 156823 [details] Patch
James Robinson
Comment 2 2012-08-06 18:52:18 PDT
Some cleanup that I've been sitting on for a while. This is prepwork for switching the PlatformLayer type over to WebLayer for the chromium port.
WebKit Review Bot
Comment 3 2012-08-06 18:52:40 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Antoine Labour
Comment 4 2012-08-06 18:54:59 PDT
LGTM
Adrienne Walker
Comment 5 2012-08-06 18:57:52 PDT
Comment on attachment 156823 [details] Patch R=me. Maybe some day we can get rid of clearRenderSurface()...
James Robinson
Comment 6 2012-08-06 19:20:07 PDT
Comment on attachment 156823 [details] Patch Yeah, someday! Maybe separating the wrapper type from the type that RenderSurfaceChromium refers to will be the answer.
WebKit Review Bot
Comment 7 2012-08-06 20:37:40 PDT
Comment on attachment 156823 [details] Patch Clearing flags on attachment: 156823 Committed r124841: <http://trac.webkit.org/changeset/124841>
WebKit Review Bot
Comment 8 2012-08-06 20:37:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.