Bug 93313

Summary: [chromium] add sync points and GL_CHROMIUM_texture_mailbox entrypoints to WebGraphicsContext3D
Product: WebKit Reporter: Antoine Labour <piman>
Component: New BugsAssignee: Antoine Labour <piman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, enne, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Antoine Labour 2012-08-06 17:53:10 PDT 
[chromium] add sync points and GL_CHROMIUM_texture_mailbox entrypoints to WebGraphicsContext3D
Comment 1 Antoine Labour 2012-08-06 17:53:59 PDT 
Created attachment 156814 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-06 17:55:55 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 James Robinson 2012-08-06 17:56:41 PDT 
Comment on attachment 156814 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156814&action=review

> Source/Platform/chromium/public/WebGraphicsContext3D.h:175
> +    virtual unsigned int insertSyncPoint() { return 0; }
> +    virtual void waitSyncPoint(unsigned int) { }

we normally just use "unsigned" as the type name in WebKit (although this isn't universal).
Comment 4 Antoine Labour 2012-08-06 18:03:46 PDT 
Created attachment 156815 [details]
Patch for landing
Comment 5 Antoine Labour 2012-08-06 18:04:26 PDT 
(In reply to comment #3)
> (From update of attachment 156814 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156814&action=review
> 
> > Source/Platform/chromium/public/WebGraphicsContext3D.h:175
> > +    virtual unsigned int insertSyncPoint() { return 0; }
> > +    virtual void waitSyncPoint(unsigned int) { }
> 
> we normally just use "unsigned" as the type name in WebKit (although this isn't universal).

Yep. Done.
Comment 6 WebKit Review Bot 2012-08-06 20:18:54 PDT 
Comment on attachment 156815 [details]
Patch for landing

Clearing flags on attachment: 156815

Committed r124840: <http://trac.webkit.org/changeset/124840>
Comment 7 WebKit Review Bot 2012-08-06 20:18:59 PDT 
All reviewed patches have been landed.  Closing bug.