| Summary: | [chromium] Convert WebScrollbarThemeGeometry from a concrete class to an interface | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adrienne Walker <enne> | ||||||
| Component: | New Bugs | Assignee: | Adrienne Walker <enne> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, andersca, cc-bugs, dglazkov, enne, fishd, jamesr, tkent+wkapi, tonikitoo, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Adrienne Walker
2012-08-06 16:31:55 PDT
Created attachment 156790 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 156790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156790&action=review > Source/WebCore/platform/chromium/support/WebScrollbarThemeGeometryNative.h:29 > +#include "ScrollbarThemeComposite.h" mind moving this#include to the .cpp? You don't deref this type in any inline functions, so a forward decl would work here (In reply to comment #3) > (From update of attachment 156790 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156790&action=review > > > Source/WebCore/platform/chromium/support/WebScrollbarThemeGeometryNative.h:29 > > +#include "ScrollbarThemeComposite.h" > > mind moving this#include to the .cpp? You don't deref this type in any inline functions, so a forward decl would work here Done. Created attachment 156807 [details]
Patch for landing
Comment on attachment 156807 [details] Patch for landing Clearing flags on attachment: 156807 Committed r124839: <http://trac.webkit.org/changeset/124839> All reviewed patches have been landed. Closing bug. |