Bug 93308

Summary: [chromium] Convert WebScrollbarThemeGeometry from a concrete class to an interface
Product: WebKit Reporter: Adrienne Walker <enne>
Component: New BugsAssignee: Adrienne Walker <enne>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andersca, cc-bugs, dglazkov, enne, fishd, jamesr, tkent+wkapi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Adrienne Walker
Reported 2012-08-06 16:31:55 PDT
[chromium] Convert WebScrollbarThemeGeometry from a concrete class to an interface
Attachments
Patch (55.42 KB, patch)
2012-08-06 16:39 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
Patch for landing (55.51 KB, patch)
2012-08-06 17:22 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2012-08-06 16:39:19 PDT
Created attachment 156790 [details] Patch
WebKit Review Bot
Comment 2 2012-08-06 16:42:03 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
James Robinson
Comment 3 2012-08-06 17:07:09 PDT
Comment on attachment 156790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156790&action=review > Source/WebCore/platform/chromium/support/WebScrollbarThemeGeometryNative.h:29 > +#include "ScrollbarThemeComposite.h" mind moving this#include to the .cpp? You don't deref this type in any inline functions, so a forward decl would work here
Adrienne Walker
Comment 4 2012-08-06 17:22:04 PDT
(In reply to comment #3) > (From update of attachment 156790 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156790&action=review > > > Source/WebCore/platform/chromium/support/WebScrollbarThemeGeometryNative.h:29 > > +#include "ScrollbarThemeComposite.h" > > mind moving this#include to the .cpp? You don't deref this type in any inline functions, so a forward decl would work here Done.
Adrienne Walker
Comment 5 2012-08-06 17:22:12 PDT
Created attachment 156807 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-08-06 20:00:26 PDT
Comment on attachment 156807 [details] Patch for landing Clearing flags on attachment: 156807 Committed r124839: <http://trac.webkit.org/changeset/124839>
WebKit Review Bot
Comment 7 2012-08-06 20:00:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.