Bug 93287

Summary: Testcase LayoutTests/editing/input/editable-container-with-word-wrap-normal.html failing on Mac
Product: WebKit Reporter: Pravin D <pravind.2k4>
Component: HTML EditingAssignee: Pravin D <pravind.2k4>
Status: RESOLVED FIXED    
Severity: Normal CC: leviw, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.7   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Pravin D
Reported 2012-08-06 11:48:08 PDT
Testcase LayoutTests/editing/input/editable-container-with-word-wrap-normal.html failing on Mac. The test uses 'End' key press emulation to scroll to the end of the text. However 'End' key press has a different behavior on mac as compared to Windows/Linux.
Attachments
Patch (3.53 KB, text/plain)
2012-08-06 11:59 PDT, Pravin D 		no flags
Details
Patch (3.38 KB, text/plain)
2012-08-06 12:12 PDT, Pravin D 		no flags
Details
Patch (3.37 KB, patch)
2012-08-06 12:43 PDT, Pravin D 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pravin D
Comment 1 2012-08-06 11:59:23 PDT
Created attachment 156736 [details] Patch
Ryosuke Niwa
Comment 2 2012-08-06 12:05:15 PDT
Comment on attachment 156736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156736&action=review > LayoutTests/editing/input/editable-container-with-word-wrap-normal.html:39 > + debug('NOTE:The testcase uses APIs exposed by window.internals and window.testRunner. The results will be incorrect when run in their absence.'); This is so verbose! Also, it's more helpful to tell the viewer how to test it manually. So I would revise that to something like "To manually test, move the caret to the end of the line." > LayoutTests/editing/input/editable-container-with-word-wrap-normal.html:40 > + debug('The content must scroll for the caret to reach the end of the editable text.'); Also, these two lines could be included in description() separated by \ns.
Pravin D
Comment 3 2012-08-06 12:12:30 PDT
Created attachment 156741 [details] Patch
Ryosuke Niwa
Comment 4 2012-08-06 12:23:15 PDT
Comment on attachment 156741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156741&action=review I don't think we need NOTE:. > LayoutTests/editing/input/editable-container-with-word-wrap-normal.html:39 > + debug('NOTE:To manually test, move the caret to the end of the line. \nThe content must scroll for the caret to reach the end of the editable text.'); I
Pravin D
Comment 5 2012-08-06 12:43:34 PDT
Created attachment 156747 [details] Patch
WebKit Review Bot
Comment 6 2012-08-06 16:02:13 PDT
Comment on attachment 156747 [details] Patch Clearing flags on attachment: 156747 Committed r124806: <http://trac.webkit.org/changeset/124806>
WebKit Review Bot
Comment 7 2012-08-06 16:02:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.