Bug 93265 – Web Inspector: make the MemoryClassInfo class a not-template

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Alexei Filippov]

EOM

[Alexei Filippov]

Created attachment 156682 [details]
Patch

[Alexei Filippov]

Created attachment 156689 [details]
Patch

[Alexei Filippov]

Rebaselined.

[Yury Semikhatsky]

Comment on attachment 156689 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156689&action=review

> Source/WebCore/dom/MemoryInstrumentation.h:182
> +    MemoryClassInfo(MemoryObjectInfo* memoryObjectInfo, MemoryInstrumentation::ObjectType objectType)

I would thing that the ptr is used for checking if the object has already been visited before processing it. Now we only check if an object has already been processed right before adding it to the queue of deferred pointers. But the object may be already visited by the moment the deferred pointer gets processed and we probably need to add a check for the pointer.

[WebKit Review Bot]

Comment on attachment 156689 [details]
Patch

Attachment 156689 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13447307

[Yury Semikhatsky]

Comment on attachment 156689 [details]
Patch

One advantage of having "this" parameter is that the compiler will check that MemoryClassInfo template parameter is the same as the type of "this".

[Alexei Filippov]

Created attachment 156702 [details]
Patch

[Alexei Filippov]

(In reply to comment #6)
> (From update of attachment 156689 [details])
> One advantage of having "this" parameter is that the compiler will check that MemoryClassInfo template parameter is the same as the type of "this".

Ok. I made it vice versa. You don't need to explicitly specify the class. It is now deduced from the 'this' pointer.

[Ilya Tikhonovsky]

Comment on attachment 156702 [details]
Patch

strange changes of files' mode. otherwise looks good

[Build Bot]

Comment on attachment 156702 [details]
Patch

Attachment 156702 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13450130

[Yury Semikhatsky]

Comment on attachment 156702 [details]
Patch

Please revert file mode changes, otherwise looks good.

[Alexei Filippov]

Created attachment 156904 [details]
Patch

[Alexei Filippov]

(In reply to comment #11)
> (From update of attachment 156702 [details])
> Please revert file mode changes, otherwise looks good.

done
+rebaselining

[WebKit Review Bot]

Comment on attachment 156904 [details]
Patch

Rejecting attachment 156904 [details] from commit-queue.

New failing tests:
fast/speech/input-appearance-searchandspeech.html
Full output: http://queues.webkit.org/results/13449449

[WebKit Review Bot]

Created attachment 156919 [details]
Archive of layout-test-results from gce-cq-03

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[WebKit Review Bot]

Comment on attachment 156904 [details]
Patch

Clearing flags on attachment: 156904

Committed r124884: <http://trac.webkit.org/changeset/124884>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.