Summary: | [WK2][GTK] Improvements for the new spell-checking API | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mario Sanchez Prada <mario> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cgarcia, gustavo, mrobinson, webkit.review.bot | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 90268 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Mario Sanchez Prada
2012-08-06 05:57:13 PDT
Created attachment 156680 [details] Patch proposal Patch addressing the issues pointed out by Carlos in https://bugs.webkit.org/show_bug.cgi?id=90268#c25 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 156680 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=156680&action=review Please, check the comments I made here before landing, thanks! > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:485 > + if (!spellCheckingLanguages.length()) Use spellCheckingLanguages.isNull() instead. > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:517 > + context->priv->textChecker->setSpellCheckingLanguages(CString(languages)); A char* can be assigned to a CString, so I'm not sure, but I think you can pass the languages directly here: context->priv->textChecker->setSpellCheckingLanguages(languages); Committed r124763: <http://trac.webkit.org/changeset/124763> |